refactor: simplify policy reference validation and enable feature flag#1676
Merged
refactor: simplify policy reference validation and enable feature flag#1676
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to simplify Cedar policy reference validation logic and (per title) enable the Cedar authorization feature flag used by guards/services to switch to Cedar-first authorization.
Changes:
- Forces Cedar authorization to be enabled by hardcoding
isFeatureEnabled()to returntrue. - Refactors
validatePolicyReferences()to a more compact style (inlinematchAll(...).map(...)arrays and condensed exception throw).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+40
to
+41
| // return process.env.CEDAR_AUTHORIZATION_ENABLED === 'true'; | ||
| return true; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.